New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stub out WebAssembly.{compile|instantiate}Streaming #14221

Closed

nektro wants to merge 1 commit into main from nektro-patch-47652

Contributor

nektro commented Sep 28, 2024

No description provided.


          stub out WebAssembly.{compile|instantiate}Streaming

d22ab43

robobun commented Sep 28, 2024 •

edited

Loading

❌ @nektro, your commit d22ab43 has 11 failures in #4044:

test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 14 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64

test/js/node/zlib/bytesWritten.test.ts - 1 failing on 🍎 14 aarch64

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64-baseline

test/js/node/test/parallel/fs-watch-recursive-add-file-with-url.test.js - 1 failing on 🍎 14 aarch64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 14 aarch64

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 x64

test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 x64

test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 13 aarch64

test/js/web/timers/setInterval.test.js - 1 failing on 🪟 x64

test/js/web/timers/setInterval.test.js - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline

test/cli/watch/watch.test.ts - 2 failing on 🪟 x64

nektro marked this pull request as ready for review

September 28, 2024 02:13

nektro requested a review from Jarred-Sumner

September 28, 2024 02:13

Jarred-Sumner closed this

Collaborator

Jarred-Sumner commented Sep 28, 2024

We should not do this. Many libraries will attempt to use it if it's defined, and then they will fail instead of using a fallback implementation (which many do implement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet